revert: fix(anchor): serial reads are now non-blocking

This reverts commit fc2ba5f8d1.

reason: making serail reads non-blocking caused serial data issues
because sometimes it would exit before actually seeing a newline

flake.lock

@@ -24,16 +24,16 @@
         "nixpkgs": "nixpkgs"
       },
       "locked": {
-        "lastModified": 1770108954,
-        "narHash": "sha256-VBj6bd4LPPSfsZJPa/UPPA92dOs6tmQo0XZKqfz/3W4=",
+        "lastModified": 1775216071,
+        "narHash": "sha256-PrPW70Fh1uLx3JxNV/NLeXjUhgfrZmi7ac8LJOlS0q4=",
         "owner": "lopsided98",
         "repo": "nix-ros-overlay",
-        "rev": "3d05d46451b376e128a1553e78b8870c75d7753a",
+        "rev": "197a2b55c4ed24f8b885a5b20b65f426fb6d57ca",
         "type": "github"
       },
       "original": {
         "owner": "lopsided98",
-        "ref": "develop",
+        "ref": "master",
         "repo": "nix-ros-overlay",
         "type": "github"
       }

flake.nix

@@ -2,7 +2,7 @@
   description = "Development environment for ASTRA Anchor";
 
   inputs = {
-    nix-ros-overlay.url = "github:lopsided98/nix-ros-overlay/develop";
+    nix-ros-overlay.url = "github:lopsided98/nix-ros-overlay/master";
     nixpkgs.follows = "nix-ros-overlay/nixpkgs"; # IMPORTANT!!!
 
     treefmt-nix = {
@@ -98,7 +98,8 @@
     );
 
   nixConfig = {
-    extra-substituters = [ "https://ros.cachix.org" ];
-    extra-trusted-public-keys = [ "ros.cachix.org-1:dSyZxI8geDCJrwgvCOHDoAfOm5sV1wCPjBkKL+38Rvo=" ];
+    # Cache to pull ros packages from
+    extra-substituters = [ "https://ros.cachix.org" "https://attic.iid.ciirc.cvut.cz/ros" ];
+    extra-trusted-public-keys = [ "ros.cachix.org-1:dSyZxI8geDCJrwgvCOHDoAfOm5sV1wCPjBkKL+38Rvo=" "ros:JR95vUYsShSqfA1VTYoFt1Nz6uXasm5QrcOsGry9f6Q=" ];
   };
 }

scripts/reset-repo.bash

@@ -3,7 +3,7 @@
 repo_root="$(git rev-parse --show-toplevel)"
 
 if [[ -z $repo_root ]]; then
-  echo "script must be run from within the rover-ros2 repo" >&2
+  echo "script must be run from within a git repo" >&2
   exit 1
 fi
 

src/anchor_pkg/anchor_pkg/anchor_node.py

@@ -22,15 +22,15 @@ class Anchor(Node):
     """
     Publishers:
     * /anchor/from_vic/debug
-        - Every string received from the MCU is published here for debugging (String)
+        - Every string received from the MCU is published here for debugging
     * /anchor/from_vic/core
         - VicCAN messages for Core node
     * /anchor/from_vic/arm
-        - VicCAN messages for Arm node (also receives digit messages)
+        - VicCAN messages for Arm node
     * /anchor/from_vic/bio
-        - VicCAN messages for Bio node (also receives digit messages)
+        - VicCAN messages for Bio node
     * /anchor/to_vic/debug
-        - String copy of all messages sent to the connector
+        - A string copy of the messages published to ./relay are published here
 
     Subscribers:
     * /anchor/from_vic/mock_mcu
@@ -38,9 +38,10 @@ class Anchor(Node):
     * /anchor/to_vic/relay
         - Core, Arm, and Bio publish VicCAN messages to this topic to send to the MCU
     * /anchor/to_vic/relay_string
-        - Send raw strings to connectors. Does not work for CANConnector
+        - Send raw strings to connectors. Does not work for connectors that require conversion (like CANConnector)
     * /anchor/relay
-        - (Deprecated) Legacy topic. Takes String, converts to VicCAN, then sends to connector
+        - Legacy method for talking to connectors. Takes String as input, but does not send the raw strings to connectors.
+          Instead, it converts them to VicCAN messages first.
     """
 
     connector: Connector
@@ -50,7 +51,7 @@ class Anchor(Node):
 
         logger = self.get_logger()
 
-        # ROS2 parameter setup
+        # ROS2 Parameter Setup
 
         self.declare_parameter(
             "connector",
@@ -85,7 +86,7 @@ class Anchor(Node):
             ),
         )
 
-        # determine which connector to use. options are Mock, Serial, and CAN
+        # Determine which connector to use. Options are Mock, Serial, and CAN
         connector_select = (
             self.get_parameter("connector").get_parameter_value().string_value
         )
@@ -125,9 +126,9 @@ class Anchor(Node):
                 )
                 exit(1)
 
-        # ROS2 topic setup
+        # ROS2 Topic Setup
 
-        # publishers
+        # Publishers
         self.fromvic_debug_pub_ = self.create_publisher(  # only used by serial
             String,
             "/anchor/from_vic/debug",
@@ -148,14 +149,14 @@ class Anchor(Node):
             "/anchor/from_vic/bio",
             20,
         )
-        # debug publisher for outgoing messages
+        # Debug publisher
         self.tovic_debug_pub_ = self.create_publisher(
             String,
             "/anchor/to_vic/debug",
             20,
         )
 
-        # subscribers
+        # Subscribers
         self.tovic_sub_ = self.create_subscription(
             VicCAN,
             "/anchor/to_vic/relay",

src/anchor_pkg/anchor_pkg/connector.py

@@ -429,7 +429,7 @@ class CANConnector(Connector):
 class MockConnector(Connector):
     def __init__(self, logger: RcutilsLogger, clock: Clock):
         super().__init__(logger, clock)
-        # no hardware interface for MockConnector. publish to `/anchor/from_vic/mock_mcu` instead
+        # No hardware interface for MockConnector. Publish to `/anchor/from_vic/mock_mcu` instead.
 
     def read(self) -> tuple[VicCAN | None, str | None]:
         return (None, None)