style: rename arm urdf packages

* rover_urdf_pkg -> arm_description
* astra_arm_moveit_config -> arm_moveit_config

src/arm_description/package.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
-  <name>rover_urdf_pkg</name>
+  <name>arm_description</name>
   <version>1.0.0</version>
   <description>This package contains configuration data, 3D models and launch files for Clucky's arm</description>
   <maintainer email="ds0196@uah.edu">David Sharpe</maintainer>

src/arm_description/setup.py

@@ -2,7 +2,7 @@ from setuptools import find_packages, setup
 import os
 from glob import glob
 
-package_name = 'rover_urdf_pkg'
+package_name = 'arm_description'
 
 list_of_folders = ["config", "launch", "meshes", "textures", "urdf"]
 

src/arm_description/urdf/ASTRA_Arm.urdf

@@ -27,7 +27,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/base_link.STL" />
+          filename="package://arm_description/meshes/base_link.STL" />
       </geometry>
       <material
         name="">
@@ -41,7 +41,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/base_link.STL" />
+          filename="package://arm_description/meshes/base_link.STL" />
       </geometry>
     </collision>
   </link>
@@ -68,7 +68,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Axis_0_Plate.STL" />
+          filename="package://arm_description/meshes/Axis_0_Plate.STL" />
       </geometry>
       <material
         name="">
@@ -82,7 +82,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Axis_0_Plate.STL" />
+          filename="package://arm_description/meshes/Axis_0_Plate.STL" />
       </geometry>
     </collision>
   </link>
@@ -128,7 +128,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Axis_1_Segment.STL" />
+          filename="package://arm_description/meshes/Axis_1_Segment.STL" />
       </geometry>
       <material
         name="">
@@ -142,7 +142,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Axis_1_Segment.STL" />
+          filename="package://arm_description/meshes/Axis_1_Segment.STL" />
       </geometry>
     </collision>
   </link>
@@ -188,7 +188,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Axis_2_Segment.STL" />
+          filename="package://arm_description/meshes/Axis_2_Segment.STL" />
       </geometry>
       <material
         name="">
@@ -202,7 +202,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Axis_2_Segment.STL" />
+          filename="package://arm_description/meshes/Axis_2_Segment.STL" />
       </geometry>
     </collision>
   </link>
@@ -248,7 +248,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Wrist.STL" />
+          filename="package://arm_description/meshes/Wrist.STL" />
       </geometry>
       <material
         name="">
@@ -262,7 +262,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Wrist.STL" />
+          filename="package://arm_description/meshes/Wrist.STL" />
       </geometry>
     </collision>
   </link>
@@ -308,7 +308,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Diff_Carrier.STL" />
+          filename="package://arm_description/meshes/Diff_Carrier.STL" />
       </geometry>
       <material
         name="">
@@ -322,7 +322,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/Diff_Carrier.STL" />
+          filename="package://arm_description/meshes/Diff_Carrier.STL" />
       </geometry>
     </collision>
   </link>
@@ -368,7 +368,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/End_Effector.STL" />
+          filename="package://arm_description/meshes/End_Effector.STL" />
       </geometry>
       <material
         name="">
@@ -382,7 +382,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/End_Effector.STL" />
+          filename="package://arm_description/meshes/End_Effector.STL" />
       </geometry>
     </collision>
   </link>
@@ -423,7 +423,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/EF_Gripper_Right.STL" />
+          filename="package://arm_description/meshes/EF_Gripper_Right.STL" />
       </geometry>
       <material
         name="">
@@ -437,7 +437,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/EF_Gripper_Right.STL" />
+          filename="package://arm_description/meshes/EF_Gripper_Right.STL" />
       </geometry>
     </collision>
   </link>
@@ -486,7 +486,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/EF_Gripper_Left.STL" />
+          filename="package://arm_description/meshes/EF_Gripper_Left.STL" />
       </geometry>
       <material
         name="">
@@ -500,7 +500,7 @@
         rpy="0 0 0" />
       <geometry>
         <mesh
-          filename="package://rover_urdf_pkg/meshes/EF_Gripper_Left.STL" />
+          filename="package://arm_description/meshes/EF_Gripper_Left.STL" />
       </geometry>
     </collision>
   </link>

src/arm_moveit_config/.setup_assistant

@@ -1,6 +1,6 @@
 moveit_setup_assistant_config:
   urdf:
-    package: rover_urdf_pkg
+    package: arm_description
     relative_path: urdf/ASTRA_Arm.urdf
   srdf:
     relative_path: config/ASTRA_Arm.srdf

src/arm_moveit_config/CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.22)
-project(astra_arm_moveit_config)
+project(arm_moveit_config)
 
 find_package(ament_cmake REQUIRED)
 

src/arm_moveit_config/config/ASTRA_Arm.urdf.xacro

@@ -3,7 +3,7 @@
     <xacro:arg name="initial_positions_file" default="initial_positions.yaml" />
 
     <!-- Import ASTRA_Arm urdf file -->
-    <xacro:include filename="$(find rover_urdf_pkg)/urdf/ASTRA_Arm.urdf" />
+    <xacro:include filename="$(find arm_description)/urdf/ASTRA_Arm.urdf" />
 
     <!-- Import control_xacro -->
     <xacro:include filename="ASTRA_Arm.ros2_control.xacro" />

src/arm_moveit_config/launch/demo.launch.py

@@ -28,7 +28,7 @@ from launch_ros.descriptions import ComposableNode
 
 
 def generate_launch_description():
-    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="astra_arm_moveit_config").to_moveit_configs()
+    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="arm_moveit_config").to_moveit_configs()
     # return generate_demo_launch(moveit_config)
     launch_package_path = moveit_config.package_path
 
@@ -119,7 +119,7 @@ def generate_launch_description():
 
     # Get parameters for the Servo node
     servo_params = {
-        "moveit_servo": ParameterBuilder("astra_arm_moveit_config")
+        "moveit_servo": ParameterBuilder("arm_moveit_config")
         .yaml("config/astra_arm_simulated_config.yaml")
         .to_dict()
     }

src/arm_moveit_config/launch/move_group.launch.py

@@ -3,5 +3,5 @@ from moveit_configs_utils.launches import generate_move_group_launch
 
 
 def generate_launch_description():
-    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="astra_arm_moveit_config").to_moveit_configs()
+    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="arm_moveit_config").to_moveit_configs()
     return generate_move_group_launch(moveit_config)

src/arm_moveit_config/launch/moveit_rviz.launch.py

@@ -3,5 +3,5 @@ from moveit_configs_utils.launches import generate_moveit_rviz_launch
 
 
 def generate_launch_description():
-    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="astra_arm_moveit_config").to_moveit_configs()
+    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="arm_moveit_config").to_moveit_configs()
     return generate_moveit_rviz_launch(moveit_config)

src/arm_moveit_config/launch/rsp.launch.py

@@ -3,5 +3,5 @@ from moveit_configs_utils.launches import generate_rsp_launch
 
 
 def generate_launch_description():
-    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="astra_arm_moveit_config").to_moveit_configs()
+    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="arm_moveit_config").to_moveit_configs()
     return generate_rsp_launch(moveit_config)

src/arm_moveit_config/launch/setup_assistant.launch.py

@@ -3,5 +3,5 @@ from moveit_configs_utils.launches import generate_setup_assistant_launch
 
 
 def generate_launch_description():
-    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="astra_arm_moveit_config").to_moveit_configs()
+    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="arm_moveit_config").to_moveit_configs()
     return generate_setup_assistant_launch(moveit_config)

src/arm_moveit_config/launch/spawn_controllers.launch.py

@@ -24,7 +24,7 @@ from moveit_configs_utils.launch_utils import (
 
 
 def generate_launch_description():
-    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="astra_arm_moveit_config").to_moveit_configs()
+    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="arm_moveit_config").to_moveit_configs()
     # return generate_spawn_controllers_launch(moveit_config)
     controller_names = moveit_config.trajectory_execution.get(
         "moveit_simple_controller_manager", {}

src/arm_moveit_config/launch/static_virtual_joint_tfs.launch.py

@@ -3,5 +3,5 @@ from moveit_configs_utils.launches import generate_static_virtual_joint_tfs_laun
 
 
 def generate_launch_description():
-    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="astra_arm_moveit_config").to_moveit_configs()
+    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="arm_moveit_config").to_moveit_configs()
     return generate_static_virtual_joint_tfs_launch(moveit_config)

src/arm_moveit_config/launch/warehouse_db.launch.py

@@ -3,5 +3,5 @@ from moveit_configs_utils.launches import generate_warehouse_db_launch
 
 
 def generate_launch_description():
-    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="astra_arm_moveit_config").to_moveit_configs()
+    moveit_config = MoveItConfigsBuilder("ASTRA_Arm", package_name="arm_moveit_config").to_moveit_configs()
     return generate_warehouse_db_launch(moveit_config)

src/arm_moveit_config/package.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
-  <name>astra_arm_moveit_config</name>
+  <name>arm_moveit_config</name>
   <version>0.3.0</version>
   <description>
      An automatically generated package with all the configuration and launch files for using the ASTRA_Arm with the MoveIt Motion Planning Framework
@@ -37,7 +37,7 @@
   <exec_depend>moveit_ros_warehouse</exec_depend>
   <exec_depend>moveit_setup_assistant</exec_depend>
   <exec_depend>robot_state_publisher</exec_depend>
-  <exec_depend>rover_urdf_pkg</exec_depend>
+  <exec_depend>arm_description</exec_depend>
   <exec_depend>rviz2</exec_depend>
   <exec_depend>rviz_common</exec_depend>
   <exec_depend>rviz_default_plugins</exec_depend>

src/servo_arm_twist_pkg/CMakeLists.txt

@@ -54,9 +54,9 @@ foreach(Dependency IN ITEMS ${THIS_PACKAGE_INCLUDE_DEPENDS})
   find_package(${Dependency} REQUIRED)
 endforeach()
 
-include_directories(
-  include
-)
+# include_directories(
+#   include
+# )
 
 ###################
 ## C++ Libraries ##
@@ -140,7 +140,7 @@ install(
   LIBRARY DESTINATION lib
   ARCHIVE DESTINATION lib
   RUNTIME DESTINATION bin
-  INCLUDES DESTINATION include
+  # INCLUDES DESTINATION include
 )
 
 # # Install Binaries
@@ -155,10 +155,10 @@ install(
 #   RUNTIME DESTINATION lib/${PROJECT_NAME}
 # )
 
-# Install include, launch, config directories
-install(DIRECTORY include/ DESTINATION include)
-install(DIRECTORY launch DESTINATION share/${PROJECT_NAME})
-install(DIRECTORY config DESTINATION share/${PROJECT_NAME})
+# # Install include, launch, config directories
+# install(DIRECTORY include/ DESTINATION include)
+# install(DIRECTORY launch DESTINATION share/${PROJECT_NAME})
+# install(DIRECTORY config DESTINATION share/${PROJECT_NAME})
 
 ament_export_targets(export_${PROJECT_NAME} HAS_LIBRARY_TARGET)
 ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS})